-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 74 rdf type vs schema additional type #95
Feature 74 rdf type vs schema additional type #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good. The one thing I noticed is that we should probably update the text in the CONVENTIONS.md in the section Typing to External Vocabularies to reflect the change to using @type
. Most of the text in that section can probably be replaced with a description of how to use external types. I would recommend it include an overview of what happens in the Google Structured Data Testing Tool and a good example or two.
Great! thanks @mbjones. I've updated CONVENTIONS.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @mbjones (mac keyboard issue has been a pain). i can't approve my own pull request if someone else here can do that, that'd be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adam, the use of @type
guidelines look good to me. I merged in recent changes from develop
, and then fixed some typos and wording in the feature branch. So, I think it is ready to be merged.
Completes issue #74
Most of the ADR had already been adopted.
schema:additionalType
; moved to@type