-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 72 provenance #134
Conversation
… relationships. Editing not completed yet on the guide, and still need to generate figures to illustrate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @mdjones. Just suggested we might use @id
so that it links to the resource and not the textual URL? thoughts?
examples/dataset/full.jsonld
Outdated
@@ -210,5 +212,13 @@ | |||
} | |||
] | |||
} | |||
] | |||
], | |||
"prov:wasDerivedFrom": "https://doi.org/10.xxxx/Dataset-1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to use @id
to link to resources? thoughts?
"prov:wasDerivedFrom": { "@id": "https://doi.org/10.xxxx/Dataset-1"},
"schema:isBasedOn": { "@id": "https://doi.org/10.xxxx/Dataset-1"},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point. I'll make the "@id" changes.
guides/Dataset.md
Outdated
"@id": "https://doi.org/10.xxxx/Dataset-2", | ||
"@type": "Dataset", | ||
"name": "Removal of organic carbon by natural bacterioplankton communities as a function of pCO2 from laboratory experiments between 2012 and 2016", | ||
<strong>"prov:wasDerivedFrom": "https://doi.org/10.xxxx/Dataset-1"</strong>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use @id
?
guides/Dataset.md
Outdated
"@id": "https://doi.org/10.xxxx/Dataset-2", | ||
"@type": "Dataset", | ||
"name": "Removal of organic carbon by natural bacterioplankton communities as a function of pCO2 from laboratory experiments between 2012 and 2016", | ||
"prov:wasDerivedFrom": "https://doi.org/10.xxxx/Dataset-1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use @id
?
I made the |
PR for provenance additions as discussed in #72. This adds guidelines for describing derived datasets, previous versions, and software workflows using mainly predicates from the PROV and ProvONE vocabularies.
I cleaned up editing for this branch, brought it up to date with
develop
, and added an example tofull.jsonld
for guidance. No substantive changes were made since we last discussed this on one of our calls and agreed to the approach. I checked the resulting full.jsonld in the JSON-LD playground and all seems to resolve.