Develop-123-tuvx-radiation-grid #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boulderdaze
reviewed
Oct 23, 2024
Comment on lines
+22
to
+24
| [ photolysis_wavelength_grid_interfaces ] | ||
| standard_name = photolysis_wavelength_grid_interfaces | ||
| units = m |
There was a problem hiding this comment.
In the configuration (ts1_tsmlt.json), the unit is nm. Are we going to use m and to add conversion?
There was a problem hiding this comment.
I saw the conversion. never mind!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates TUV-x wrapper, tests, and configuration data to allow setting the wavelength grid from the host model. This implementation assumes that there will be a standard-named variable that defines the edges of the wavelength grid to use for photolysis rate constant calculations that is defined by the host model.
Once this gets merged into
development#123 can be closed.