Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major mosart refactor including addition of new halo capability #76

Merged
merged 37 commits into from
Jun 6, 2024
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
3e00afc
Merge pull request #5 from mvertens/feature/remove_mct
mvertens Dec 24, 2023
4e66eb6
moved files to new name
mvertens Dec 31, 2023
cdd878d
major refactor of mosart code
mvertens Dec 31, 2023
291d2c5
addressed most changes requested in PR
mvertens Jan 1, 2024
7b5c498
added only attributes to all use statements in mosart_io.F90
mvertens Jan 2, 2024
46fa3c7
removed most hard-wired character lengths in mostart_histfile.F90
mvertens Jan 2, 2024
e020591
fixed issue with adding use only for mosart_io in mosart_histfile.F90
mvertens Jan 2, 2024
290d1b7
more cleanup of character string length
mvertens Jan 2, 2024
fcf7573
more character length fixes
mvertens Jan 2, 2024
5779c29
yet more character length cleanup
mvertens Jan 2, 2024
06fa17c
Module description mosart_physics_mod.F90
mvdebolskiy Jan 12, 2024
d27cef7
updates to mosart from sean
Jan 5, 2024
9113cd5
changes to compute gradient
Jan 11, 2024
ff80ba2
removal of some global arrays in initialization and addition of namel…
mvertens Jan 12, 2024
0be8c83
remamed fiels mosart_mod.F90 and mosart_physics_mod.F90
mvertens Jan 15, 2024
67e7b35
added namelist input for euler calculation option
mvertens Jan 16, 2024
33f5314
fix gradient
swensosc Jan 17, 2024
d004465
merge w/ major_refactor
swensosc Jan 17, 2024
36ef673
2nd attempt
swensosc Jan 17, 2024
b8e008d
Merge pull request #1 from swensosc/add_gradient
mvertens Jan 18, 2024
172f2f7
Merge remote-tracking branch 'escomp/master' into noresm
mvertens Feb 7, 2024
f886d12
Merge pull request #9 from mvertens/feature/update_to_escomp_master
mvertens Feb 7, 2024
37d06f2
added missing includ_user_mods files
mvertens Feb 20, 2024
ce4c1a8
Merge branch 'noresm' into feature/major_refactor
mvertens Feb 21, 2024
02b33fe
fixed compilation problem
mvertens Feb 21, 2024
a57cdb1
typo and nl desc for finidat
mvdebolskiy Feb 21, 2024
73e2a01
remove unused evaporation fluxes
mvdebolskiy Feb 21, 2024
7bf49ef
mark variables to delete with NOT_USED, verbose comments
mvdebolskiy Feb 21, 2024
ed42666
add TODOs and more NOT_USED
mvdebolskiy Feb 21, 2024
5a66730
refactor mosart budget code
mvdebolskiy Feb 23, 2024
881fb9d
Fixed test category for betsy versus izumi in one test
slevis-lmwg Jun 5, 2024
8fd9474
fixed compilation problems with nag
Jun 6, 2024
5ef5206
addressed https://github.com/ESCOMP/MOSART/issues/93
Jun 6, 2024
377d6ca
reverted changes in mosart_io.F90 since they caused the model to cras…
Jun 6, 2024
3c7b9d1
updates to fix pio error checking in mosart_io.F90
Jun 6, 2024
641414c
Update a user_nl_mosart comment
slevis-lmwg Jun 6, 2024
2695f36
Updated ChangeLog
slevis-lmwg Jun 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions cime_config/buildnml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def _create_namelists(case, confdir, inst_string, infile, nmlgen, data_list_path
#----------------------------------------------------

run_type = case.get_value("RUN_TYPE")
finidat_rtm = str(nmlgen.get_value("finidat_rtm"))
finidat = str(nmlgen.get_value("finidat"))
if run_type == 'branch' or run_type == 'hybrid':
run_refcase = case.get_value("RUN_REFCASE")
run_refdate = case.get_value("RUN_REFDATE")
Expand All @@ -90,17 +90,17 @@ def _create_namelists(case, confdir, inst_string, infile, nmlgen, data_list_path
filename = "%s.mosart.r.%s-%s.nc" %(run_refcase, run_refdate, run_tod)

if run_type == "hybrid":
nmlgen.add_default("finidat_rtm", value=filename, ignore_abs_path=True)
nmlgen.add_default("finidat", value=filename, ignore_abs_path=True)
else:

nmlgen.add_default("nrevsn_rtm", value=filename)
elif finidat_rtm.strip() == '':
nmlgen.set_value('finidat_rtm', value=' ')
nmlgen.add_default("nrevsn", value=filename)
elif finidat.strip() == '':
nmlgen.set_value('finidat', value=' ')
else:
if nmlgen.get_default('finidat_rtm') == 'UNSET':
nmlgen.add_default('finidat_rtm', value=' ', ignore_abs_path=True)
if nmlgen.get_default('finidat') == 'UNSET':
nmlgen.add_default('finidat', value=' ', ignore_abs_path=True)
else:
nmlgen.add_default("finidat_rtm")
nmlgen.add_default("finidat")

ncpl_base_period = case.get_value('NCPL_BASE_PERIOD')
if ncpl_base_period == 'hour':
Expand Down Expand Up @@ -131,8 +131,8 @@ def _create_namelists(case, confdir, inst_string, infile, nmlgen, data_list_path
coupling_period = basedt // mosart_ncpl
nmlgen.set_value("coupling_period", value=coupling_period)

if ( nmlgen.get_value("frivinp_rtm") == "UNSET" and config["mosart_mode"] != "NULL" ):
raise SystemExit("ERROR: Direction file is NOT set and is required when MOSART is active: frivinp_rtm")
if ( nmlgen.get_value("frivinp") == "UNSET" and config["mosart_mode"] != "NULL" ):
raise SystemExit("ERROR: Direction file is NOT set and is required when MOSART is active: frivinp")

bypass_routing_option = nmlgen.get_value("bypass_routing_option")
qgwl_runoff_option = nmlgen.get_value("qgwl_runoff_option")
Expand Down
56 changes: 28 additions & 28 deletions cime_config/namelist_definition_mosart.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,6 @@
<!-- MOSART Namelist -->
<!-- ======================================================================================== -->

<entry id="do_rtmflood" modify_via_xml="MOSART_FLOOD_MODE">
<type>logical</type>
<category>mosart</category>
<group>mosart_inparm</group>
<values>
<value mosart_flood_mode="ACTIVE">.true.</value>
<value mosart_flood_mode="NULL">.false.</value>
</values>
<desc>
If .true., turn on mosart flooding back to clm
Note that mosart flood is not supported in CESM1.1
</desc>
</entry>

<entry id="ice_runoff">
<type>logical</type>
<category>mosart</category>
Expand Down Expand Up @@ -74,6 +60,20 @@
</desc>
</entry>

<entry id="use_halo_option">
<type>logical</type>
<category>mosart</category>
<group>mosart_inparm</group>
<values>
<value>.false.</value>
</values>
<desc>
If true, add capability to have halo option for mosart fields.
In particular these can be used to create derivatives using halo values
from neighboring cells.
</desc>
</entry>

<entry id="bypass_routing_option">
<type>char</type>
<category>mosart</category>
Expand Down Expand Up @@ -101,7 +101,7 @@
</desc>
</entry>

<entry id="finidat_rtm" skip_default_entry="true">
<entry id="finidat" skip_default_entry="true">
<type>char</type>
<category>mosart</category>
<group>mosart_inparm</group>
Expand All @@ -110,11 +110,11 @@
<value>UNSET</value>
</values>
<desc>
Full pathname of initial rtm file
Full pathname of initialfile
</desc>
</entry>

<entry id="nrevsn_rtm" skip_default_entry="true">
<entry id="nrevsn" skip_default_entry="true">
<type>char</type>
<category>mosart</category>
<group>mosart_inparm</group>
Expand All @@ -126,7 +126,7 @@
</desc>
</entry>

<entry id="frivinp_rtm">
<entry id="frivinp">
<type>char</type>
<category>mosart</category>
<input_pathname>abs</input_pathname>
Expand All @@ -138,11 +138,11 @@
<value rof_grid="0.125nldas2">$DIN_LOC_ROOT/rof/mosart/MOSART_routing_0.125nldas2_cdf5_c200727.nc</value>
</values>
<desc>
Full pathname of input datafile for RTM.
Full pathname of input mosart datafile
</desc>
</entry>

<entry id="rtmhist_fexcl1">
<entry id="fexcl1">
<type>char(1000)</type>
<category>history</category>
<group>mosart_inparm</group>
Expand All @@ -154,7 +154,7 @@
</desc>
</entry>

<entry id="rtmhist_fexcl2">
<entry id="fexcl2">
<type>char(1000)</type>
<category>history</category>
<group>mosart_inparm</group>
Expand All @@ -166,7 +166,7 @@
</desc>
</entry>

<entry id="rtmhist_fexcl3">
<entry id="fexcl3">
<type>char(1000)</type>
<category>history</category>
<group>mosart_inparm</group>
Expand All @@ -178,7 +178,7 @@
</desc>
</entry>

<entry id="rtmhist_fincl1">
<entry id="fincl1">
<type>char(1000)</type>
<category>history</category>
<group>mosart_inparm</group>
Expand All @@ -190,7 +190,7 @@
</desc>
</entry>

<entry id="rtmhist_fincl2">
<entry id="fincl2">
<type>char(1000)</type>
<category>history</category>
<group>mosart_inparm</group>
Expand All @@ -202,7 +202,7 @@
</desc>
</entry>

<entry id="rtmhist_fincl3">
<entry id="fincl3">
<type>char(1000)</type>
<category>history</category>
<group>mosart_inparm</group>
Expand All @@ -214,7 +214,7 @@
</desc>
</entry>

<entry id="rtmhist_mfilt">
<entry id="mfilt">
<type>integer(6)</type>
<category>history</category>
<group>mosart_inparm</group>
Expand All @@ -226,7 +226,7 @@
</desc>
</entry>

<entry id="rtmhist_ndens">
<entry id="ndens">
<type>integer(6)</type>
<category>history</category>
<group>mosart_inparm</group>
Expand All @@ -240,7 +240,7 @@
</desc>
</entry>

<entry id="rtmhist_nhtfrq">
<entry id="nhtfrq">
<type>integer(6)</type>
<category>history</category>
<group>mosart_inparm</group>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
! ice_runoff = .true.
rtmhist_ndens = 1,1,1
rtmhist_nhtfrq =-24,-8
rtmhist_mfilt = 1,1
! ice_runoff = .true.
ndens = 1,1,1
nhtfrq =-24,-8
mfilt = 1,1
Loading