-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mosart1.1.08: Standardize time metadata #66
mosart1.1.08: Standardize time metadata #66
Conversation
@slevis-lmwg @jedwards4b - I think this should be merged at this point. I can also bring these changes into #76 once it is merged. |
Thank you @mvertens. |
…tadata slevis resolved conflicts: src/riverroute/RtmHistFile.F90
Adding here separately to facilitate testing.
Fix for Nag compiler Fix nag compiler, change ChangeLog to markdown format. Remove complexity of having curr_date_in in timemgr_init be optional and make it required. As was done in RTM.
I will initiate testing, update the ChangeLog, and make a new tag. |
Standardize time metadata (release tag for ctsm5.3) Last of the 3 "history" tags that ended up numbered as follows: ctsm5.3.018 time now middle of time_bounds ctsm5.3.019 eliminate 0th time step ctsm5.3.021 standardize time metadata As the release tag for ctsm5.3, this also includes the file WhatsNewInCTSM5.3.md. PRs that document the changes ESCOMP#2052 ESCOMP/MOSART#66 ESCOMP/RTM#35
Standardize time metadata (release tag for ctsm5.3) Last of the 3 "history" tags that ended up numbered as follows: ctsm5.3.018 time now middle of time_bounds ctsm5.3.019 eliminate 0th time step ctsm5.3.021 standardize time metadata As the release tag for ctsm5.3, this also includes the file WhatsNewInCTSM5.3.md. PRs that document the changes ESCOMP#2052 ESCOMP/MOSART#66 ESCOMP/RTM#35
Standardize time metadata (release tag for ctsm5.3) Last of the 3 "history" tags that ended up numbered as follows: ctsm5.3.018 time now middle of time_bounds ctsm5.3.019 eliminate 0th time step ctsm5.3.021 standardize time metadata As the release tag for ctsm5.3, this also includes the file WhatsNewInCTSM5.3.md. PRs that document the changes ESCOMP#2052 ESCOMP/MOSART#66 ESCOMP/RTM#35
Description of changes
Standardizes a dimension name of output variable
time_bounds
, as well as attributes for that plusmcdate
,mcsec
,mdcur
, andmscur
.Specific notes
Contributors other than yourself: @phillips-ad, @ekluzek
MOSART Issues Fixed:
Are answers expected to change (and if so in what way)? No.
Any User Interface Changes (namelist or namelist defaults changes)? No.
Testing performed
New metadata in a history file from a short test:
An arbitrarily-chosen CTSM test with MOSART,
SMS_D_Ld3.f10_f10_mg37.I2000Clm50BgcCru.cheyenne_gnu.clm-default
, passed bit-for-bit against tagctsm5.1.dev130
, despite the changed metadata.