Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"if (ierr /= PIO_NOERR)" will not be invoked unless PIO_BCAST_ERROR is explicitly set #93

Closed
slevis-lmwg opened this issue Jun 6, 2024 · 2 comments · Fixed by #76
Closed

"if (ierr /= PIO_NOERR)" will not be invoked unless PIO_BCAST_ERROR is explicitly set #93

slevis-lmwg opened this issue Jun 6, 2024 · 2 comments · Fixed by #76
Assignees
@mvertens
Labels
question

Comments

@slevis-lmwg
Copy link
Contributor

Unless PIO_BCAST_ERROR is explicitly set the pio error will be handled in the pio library and the code will not return to this location with an error.

Originally posted by @jedwards4b in #76 (comment)
@slevis-lmwg
Copy link
Contributor Author

Another relevant comment:
#76 (comment)

@mvertens mvertens self-assigned this Jun 6, 2024
@mvertens
Copy link
Contributor

mvertens commented Jun 6, 2024

This was indeed a problem in the refactored code and I have fixed it.

mvertens pushed a commit to mvertens/mosart that referenced this issue Jun 6, 2024
addressed ESCOMP#93
5ef5206
@mvertens mvertens mentioned this issue Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvertens mvertens

Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

major mosart refactor including addition of new halo capability mvertens/mosart
2 participants
@mvertens @slevis-lmwg