Add crop residue removal #2297
Merged
Add crop residue removal #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces hard-coded removedresidue_fraction.
samsrabin
added
the
next
Various BFB fixes and updates Purpose/description of changes ------------------------------ the default comes in a later tag (slevis) Regular and python testing passed. Does not change answers relative to dev158.
12 tasks
samsrabin
removed
the
next
samsrabin
commented
Jan 5, 2024
| call hist_addfld1d (fname='LIVESTEMC_TO_REMOVEDRESIDUEC', units='gC/m^2/s', & | ||
| avgflag='A', long_name='livestem C to removed residue C', & | ||
| ptr_patch=this%livestemc_to_removedresiduec_patch) | ||
|
|
There was a problem hiding this comment.
- Turn these off by default
slevis-lmwg
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
@samsrabin and I went over this PR. During our call, Sam R decided to make new history fields inactive, and I agreed. Other than that, this PR looks ready.
A reminder for me: When matrixcn (#640) and this branch merge in main soon, I will need to update the matrixcn side to match the updates introduced by this PR.
Improvements to processing of crop calendar files In python/ctsm/crop_calendars/, process_ggcmi_shdates.py and regrid_ggcmi_shdates.py are used to convert the raw GGCMI crop calendar files into CTSM-compatible versions. This update fixes some bugs, removes dependencies on the nco utilities, enables the use of surface datasets as template files (in addition to the existing ability to use CTSM output files), and standardizes things for consistency with other CTSM Python tools.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds parameter
crop_residue_removal_frac(default 0) that represents what fraction of post-harvest crop residues (stems and leaves) should be removed to the crop product pool rather than being transferred to litter.Specific notes
Contributors other than yourself, if any: @mwgraham, @danicalombardozzi
CTSM Issues Fixed (include github issue #): None
Are answers expected to change (and if so in what way)? Not if
crop_residue_removal_fracis default 0.Any User Interface Changes (namelist or namelist defaults changes)? Adds parameter
crop_residue_removal_frac(default 0)Testing performed, if any:
From 1-degree runs for AGU, see results with
Rlo(residue removal 50%) compared toRoff(no residue removal; previous behavior). (Toff/Thirefer to tillage settings.)Soil C:
NBP (relative to tillage and residue removal off; unitless):
Remaining tasks