Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change names on ctsm5.2 datasets to include context for "_78_" to "_78pfts" #2073

Closed
ekluzek opened this issue Jul 26, 2023 · 10 comments
Closed
Labels
priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations
Milestone

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Jul 26, 2023

Names for landuse.timeseries on the ctsm5.2 branch currently should change.

We want to go to this format:

lnd/clm2/surfdata_esmf/ctsm5.2.0/landuse.timeseries_0.9x1.25_hist_1850-2015_78pfts_c230601.nc
lnd/clm2/surfdata_esmf/ctsm5.2.0/fsurdat_0.9x1.25_hist_1850_78pfts_c230601.nc
lnd/clm2/surfdata_esmf/ctsm5.2.0/fsurdat_0.9x1.25_hist_2000_78pfts_c230601.nc
lnd/clm2/surfdata_esmf/ctsm5.2.0/fsurdat_0.9x1.25_hist_2015_78pfts_c230601.nc
lnd/clm2/surfdata_esmf/ctsm5.2.0/landuse.timeseries_0.9x1.25_SSP2-4.5_1850-2100_78pfts_c230601.nc
lnd/clm2/surfdata_esmf/ctsm5.2.0/fsurdat_0.9x1.25_SSP2-4.5_2100_78pfts_c230601.nc

The 78 part should become 78pfts

@ekluzek ekluzek added the priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations label Jul 26, 2023
@ekluzek ekluzek added this to the ctsm5.2.0 milestone Jul 26, 2023
@ekluzek
Copy link
Collaborator Author

ekluzek commented Jul 26, 2023

Also should 1850-2015 become _simyr1850-2015 as we had before?

@ekluzek ekluzek added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jul 26, 2023
@slevis-lmwg
Copy link
Contributor

@ekluzek while we're updating the file names, I have additional suggestions.

Starting from names like the one that you presented above:
landuse.timeseries_0.9x1.25_hist_78_CMIP6_1850-2015_c230601.nc
...what if we changed to:
landuse.timeseries_0.9x1.25_hist_1850-2015_78pfts_c230601.nc

I have made three changes to the file name:

  1. Added pfts back, as you recommended.
  2. Did not add simyr as it seems unnecessary to me but moved the year range right after hist because these two are related.
  3. Removed CMIP6 and understand if this needs to stay.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Jul 27, 2023

@slevis-lmwg I like your proposal. The one question I have is if we should keep CMIP6, this does tell you what generation of data was used. @lawrencepj1 do you have an opinion on keeping (or not keeping) the CMIP6 identifier in the surface dataset names? This part only changes every few years with the next CMIP cycle. I think it can be helpful to see what generation the data is from, but I'd like to hear from others if they think it's useful.

@lawrencepj1
Copy link

lawrencepj1 commented Jul 27, 2023 via email

@slevis-lmwg
Copy link
Contributor

Hi Erik I think as long as we have the CTSM version in the name we don't need to have the CMIP version as well.

So back to my example, maybe something like this?
landuse.timeseries_0.9x1.25_hist_1850-2015_78pfts_ctsm52_c230601.nc
I added the ctsm52 right before the date stamp, because the two are somewhat related.

@lawrencepj1
Copy link

lawrencepj1 commented Jul 27, 2023 via email

@slevis-lmwg
Copy link
Contributor

Reminder from meeting with @ekluzek :

  • The same renaming proposal applies to the fsurdat files, as well
  • The renaming will require a repeat of ./rimport
  • The ne120 file is large, so maybe trying an svn copy for that one if it will work

@slevis-lmwg
Copy link
Contributor

@adamrher also asks whether fsurdat files generated for transient cases need to include the range of years in their name, as is done now. I think the answer is: No, they do not and to reduce potential confusion, how about we return fsurdat names to including the start year, rather than the range.

@slevis-lmwg
Copy link
Contributor

Also, we are now discussing possibly completing #1886 to clarify when ocean is ocean and not wetland in fsurdat files. If so, then we will regenerate all fsurdat files after #1886 is completed.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Oct 4, 2023

@slevis-lmwg and I went over the naming convention and went with what what I changed the introduction to this to. Here's an example:

lnd/clm2/surfdata_esmf/ctsm5.2.0/landuse.timeseries_0.9x1.25_hist_1850-2015_78pfts_c230601.nc

ekluzek added a commit to ekluzek/CTSM that referenced this issue Oct 5, 2023
@wwieder wwieder removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Oct 19, 2023
@ekluzek ekluzek closed this as completed Jan 11, 2024
@ekluzek ekluzek moved this to Done in CTSM: High priority Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations
Projects
No open projects
Development

No branches or pull requests

4 participants