Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with xgrid reproducibility #364

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

jedwards4b
Copy link
Collaborator

Description of changes

Adds optional flags to ESMF_FieldRegridStore command to make xgrid reproducable.

Specific notes

Contributors other than yourself, if any: mvertens, esmf team

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed

Testing performed if application target is CESM:

  • (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
    • machines: cheyenne
    • details (e.g. failed tests):
  • (recommended) CESM testlist_drv.xml
    • machines and compilers:
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):
  • (other) please described in detail
    • machines and compilers cheyenne intel
    • details:
      The following tests were all rerun on the xgrid and now all PASS
      - ERP_D_Ln9_Vnuopc.f19_f19_mg17.FSD.cheyenne_intel.cam-outfrq9s_sd
      - ERP_D_Ln9_Vnuopc.ne30pg3_ne30pg3_mg17.F2000dev.cheyenne_intel.cam-outfrq9s
      - ERP_Ld3_Vnuopc.f09_f09_mg17.FCfireHIST.cheyenne_intel.cam-outfrq1d
      - ERP_Ln9_Vnuopc.f09_f09_mg17.2000_CAM60_CLM50%SP_CICE%PRES_DOCN%DOM_MOSART_SGLC_SWAV.cheyenne_intel.cam-outfrq9s
      Testing performed if application target is UFS-coupled:
  • (recommended) UFS-coupled testing
    • description:
    • details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

  • (recommended) UFS-HAFS testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

  • CESM:
  • UFS-coupled, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:
  • UFS-HAFS, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:

@jedwards4b jedwards4b requested a review from uturuncoglu April 19, 2023 15:55
@jedwards4b jedwards4b self-assigned this Apr 19, 2023
Copy link
Collaborator

@uturuncoglu uturuncoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I just wonder if you need to change also following section of code

call ESMF_FieldRegrid(field_src, field_dst, routehandle=rh_agrid2xgrid_patch, &
and also
call ESMF_FieldRegrid(field_src, field_dst, routehandle=rh_agrid2xgrid_bilinr, &
. It would be also nice to test this with UFS and maybe we could get rid of if statements but of course it will take time for me to test those. So, maybe we could aim those in the other PR.

@jedwards4b
Copy link
Collaborator Author

@uturuncoglu what additional change are you suggesting? The tests were rerun with the change that I made and no further changes are required.

@uturuncoglu
Copy link
Collaborator

@jedwards4b Okay. It is my fault. Those are ESMF_FieldRegrid calls not Store.

@mvertens
Copy link
Collaborator

@jedwards4b, @uturuncoglu - from a separate email it seems like this change requires a new ESMF tag. Is this correct. If so - this needs to be documented in this PR. Working at other institutions, requirements of new ESMF tags can be challenging.
And if indeed this is the case, this will not be backwards compatible with older ESMF libraries. Please clarify.

@jedwards4b
Copy link
Collaborator Author

@mvertens - I don't think that is the case with this one. I have another issue to add a message indicating the minimum required esmf version.

@jedwards4b jedwards4b deleted the xgrid_reproducability_fix branch April 19, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants