Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove multi_driver, add precommit config file #331

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

jedwards4b
Copy link
Collaborator

Description of changes

Multi_driver is always True for cmeps, no need for logic here.

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed

Testing performed if application target is CESM:

  • (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
    • machines:
    • details (e.g. failed tests):
  • (recommended) CESM testlist_drv.xml
    • machines and compilers:
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):
  • (other) please described in detail
    • machines and compilers
    • details (e.g. failed tests):

Testing performed if application target is UFS-coupled:

  • (recommended) UFS-coupled testing
    • description:
    • details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

  • (recommended) UFS-HAFS testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

  • CESM:
  • UFS-coupled, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:
  • UFS-HAFS, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:

@jedwards4b
Copy link
Collaborator Author

@fischer-ncar can I merge this before you start beta11 testing?

@fischer-ncar
Copy link
Contributor

@jedwards4b Yes you can merge this. I'm only going to update the cmeps tag to include #329 for beta11 testing. I want the
testing to go as smooth as possible so I can start the holiday vacation.

@jedwards4b
Copy link
Collaborator Author

No we need to merge #327 as well and I think this one should be included too.

@jedwards4b jedwards4b merged commit ce620ef into ESCOMP:master Dec 19, 2022
@jedwards4b jedwards4b deleted the remove_multi_driver branch December 19, 2022 20:41
@fischer-ncar
Copy link
Contributor

Okay, I'll include this pr and #327 in beta11 testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants