NEMS prep ocn cleanup #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to latest ESCOMP/master Co-authored-by: Jim Edwards <[email protected]> Co-authored-by: uturuncoglu <[email protected]> Co-authored-by: alperaltuntas <[email protected]> Co-authored-by: Mariana Vertenstein <[email protected]> Co-authored-by: mvertens <[email protected]>
* Enable fine-grained timing in the mediator using ESMF * Fix code comments
changes in prep_ocn
regression tests fail comparison of mediator restart files but all other files reproduce. cprnc not working on orion, so will run on hera to try to determine cause
|
@danrosen25 Your changes to CMEPS/mediator/Makefile were merged w/o review by EMC. The changes here are what EMC is currently using. Could you verify this does not break CMEPS for you? |
mvertens
approved these changes
Sep 21, 2020
|
@jedwards4b - I'd like you to review the changes to the minor and major versions via the CPP if-defs. All the other changes look fine to me. |
jedwards4b
approved these changes
Sep 21, 2020
11 tasks
jedwards4b
added a commit
to jedwards4b/CMEPS
that referenced
this pull request
Jun 9, 2022
### Description of changes Add support for downloading and checking the NEON data inventory file listing.csv Generated new baselines due to FIELDLIST field lists differ jul12 ### Specific notes Contributors other than yourself, if any: CMEPS Issues Fixed (include github issue #): Are there dependencies on other component PRs - [X] CIME (list) hash 5f05541 on the trunk - [ ] CMEPS (list) Are changes expected to change answers? - [X] bit for bit - [ ] different at roundoff level - [ ] more substantial Any User Interface Changes (namelist or namelist defaults changes)? - [ ] Yes - [X] No Testing performed: - [X] (required) aux_cdeps - machines and compilers: - details (e.g. failed tests): - [ ] (optional) CESM prealpha test - machines and compilers - details (e.g. failed tests): Hashes used for testing: - [X] CIME - repository to check out: https://github.com/ESCOMP/CESM.git - branch: - hash:5f05541 - [X] CMEPS - repository to check out: https://github.com/ESCOMP/CESM.git - branch: - hash: cmeps0.13.15 - [ ] CESM - repository to check out: https://github.com/ESCOMP/CESM.git - branch: - hash:
uturuncoglu
pushed a commit
to uturuncoglu/CMEPS
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Removes special nems_orig_data prep ocean phase which is no longer required if corresponding changes are made in esmFldsExchange_nems to make use of the auto-merge feature.
Modifies fd_nems.yaml to account for differing field names between the nems active and nems data ATM being used for the same ocean import field
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Are changes expected to change answers?
Testing on hera and orion for S2S shows all fields are b4b except for the mediator files. However, manual comparison on the mediator files using either nccmp -d or cpnrc -m show no differences.
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):
Testing performed if application target is UFS-S2S:
Hashes used for testing: