Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticking time-bomb with #if ESMF_VERSION_MINOR > 0 #105

Closed
aerorahul opened this issue Sep 25, 2020 · 2 comments
Closed

Ticking time-bomb with #if ESMF_VERSION_MINOR > 0 #105

aerorahul opened this issue Sep 25, 2020 · 2 comments

Comments

@aerorahul
Copy link
Contributor

CMEPS/mediator/esmFlds.F90

Line 361 in 01dfe9a

#if ESMF_VERSION_MINOR > 0

uh, does this make sense to anyone?
When ESMF releases 9.0.0 , this is going to blow!

Also, in several more places in https://github.com/ESCOMP/CMEPS/blob/master/mediator/esmFlds.F90
@rsdunlapiv
Copy link
Contributor

Not sure, but it might be that @danrosen25 has already addressed by this in the HAFS work. It is a problem for sure.

@jedwards4b jedwards4b mentioned this issue Nov 16, 2020
Merged
11 tasks
@billsacks
Copy link
Member

It looks like this was fixed; closing.

uturuncoglu pushed a commit to uturuncoglu/CMEPS that referenced this issue Jan 5, 2024
@JiliDong-NOAA
add flag to track lake freezing for clm lake (ESCOMP#105)
53bae53 
* add flag to track lake freezing for clm lake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rsdunlapiv @billsacks @aerorahul