cam6_3_109: Science and infrastructure changes to improve energy/mass budget reporting and closure. #761
+4,542
−1,660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le that handles the meta data involved in working with budgets similar to the way constituents are handled
Pass surface ozone concentrations to coupler
Merge pull request ESCOMP#409 from PUMASDevelopment/gettelman_pumas_update0821
nusbaume
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
All of my concerns have been resolved or properly deferred, so I am happy with this PR. Thanks @jtruesdal and @PeterHjortLauritzen for all your work on the review responses!
|
I don't have time to do a proper review |
Update FLTHIST compset and finish implementing initial FMTHIST compset
… into ebudget_dev_update
cacraigucar
approved these changes
Apr 27, 2023
jtruesdal
force-pushed
the
ebudget_dev_update
branch
from
50c8f09 to
b51b632
Compare
…on - no regression test side effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add inline energy/mass budgets support. (#519) Science changes are included that help close the mass and energy budgets of physics and the SE/MPAS dycores (#521) as well as adding all water constituents to atmospheric mass (pressure) (#520). Lastly a small fix for issue #790.
We've been testing with an interim CTSM branch that has MPAS land boundary condition files. There is a parallel PR ESCOMP/CTSM#1501 to get these updated MPAS files into the land repo.
As of this PR energy/mass budgets have been added for physics and the SE and MPAS dycores. The work of budget improvement, expansion to other supported dycores, and refactor of the logging infrastructure will continue in future PRs.
Most functional regression testing are passing and baselines are expected to fail due to the climate changing science updates.
Similar to amwg_diagnostic functionality, energy/mass budget diagnostic fields will be added to a history file via the thermo_budget_histfile_num namelist parameter. Globally averaged energy budget summaries are also calculated and written to the atm log file every time the budget history tape is written to. The period over which energy and mass budgets are averaged is the same as the averaging period of the history budget file. Thus history budgets can be output/averaged at time step, hour, or month resolutions using the nhtfrq variable specific to the budget history file identified by (.false.) The default is .false. (no budgeting) because of the global gathers needed to create the budgets.
closes #790
closes #519
closes #520
closes #521
closes #789