Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

part of cam6_2_046: get pio_file format from driver #201

Closed

Conversation

jedwards4b
Copy link

@jedwards4b jedwards4b commented Sep 1, 2020

Get the pio format from the environment variable PIO_NETCDF_FORMAT
Fixes #202.

@jedwards4b jedwards4b requested a review from gold2718 September 1, 2020 15:16
@gold2718
Copy link
Collaborator

gold2718 commented Sep 1, 2020

I am going to fold this into #200.

@gold2718 gold2718 self-assigned this Sep 1, 2020
@gold2718 gold2718 added bug-fix This PR was created to fix a specific bug. next release Required to be in next CESM Release labels Sep 1, 2020
@gold2718
Copy link
Collaborator

gold2718 commented Sep 1, 2020

@jedwards4b , @jtruesdal , has anyone tried out the changes in this PR?
We have to decide if it goes into the release and it does not seem to compile as is.

@jedwards4b
Copy link
Author

I think I know what the problem is, but @gold2718 if you could provide more information about the failure it might help.

@jedwards4b
Copy link
Author

compile issue resolved.

@gold2718
Copy link
Collaborator

gold2718 commented Sep 1, 2020

I easily fixed the compile issue in my branch but since the code did not compile, I do not understand how it was tested. Has anyone verified that this PR fixes the problem?

gold2718 pushed a commit to gold2718/CAM that referenced this pull request Sep 1, 2020
@jedwards4b
Copy link
Author

Ran test SMS_D.f19_f19.F1850 with PIO_NETCDF_FORMAT='64bit_data' and verified cam file output format.
ncdump -k run/SMS_D.f19_f19.F1850.cheyenne_intel.20200901_125449_ebam4g.cam.i.0001-01-06-00000.nc
cdf5

@cacraigucar cacraigucar changed the title get pio_file format from driver part of cam6_2_046: get pio_file format from driver Sep 1, 2020
@jtruesdal
Copy link
Collaborator

jtruesdal commented Sep 1, 2020 via email

@gold2718
Copy link
Collaborator

gold2718 commented Sep 2, 2020

Integrated into cam6_2_046 by #200

@gold2718 gold2718 closed this Sep 2, 2020
gdicker1 pushed a commit to gdicker1/CAM that referenced this pull request Oct 13, 2022
Description of changes

Remove test systems bluewaters, hobart and edison from testlists
Specific notes

Contributors other than yourself, if any:

Fixes: [Github issue #s] And brief description of each issue.

User interface changes?: [ No/Yes ]
[ If yes, describe what changed, and steps taken to ensure backward compatibility ]

Testing performed (automated tests and/or manual tests):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This PR was created to fix a specific bug. next release Required to be in next CESM Release
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants