Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spline2mesh #38

Merged
merged 21 commits into from
Jan 6, 2025
Merged

Spline2mesh #38

merged 21 commits into from
Jan 6, 2025

Conversation

faymanns
Copy link
Member

@faymanns faymanns commented Jan 6, 2025

This implements the possibility to render a spline as a mesh in 3D.
Both, surface and volume meshes are supported using triangles and tetrahedra respectively.

This closes issue #34.

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 92.42424% with 5 lines in your changes missing coverage. Please review.

Project coverage is 97.49%. Comparing base (cd5e791) to head (d91f6e2).

Files with missing lines Patch % Lines
src/splinebox/spline_curves.py 92.42% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   97.57%   97.49%   -0.08%     
==========================================
  Files           3        3              
  Lines         659      719      +60     
==========================================
+ Hits          643      701      +58     
- Misses         16       18       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@faymanns faymanns merged commit 98419de into main Jan 6, 2025
10 checks passed
@faymanns faymanns deleted the spline2mesh branch January 6, 2025 12:58
@faymanns faymanns mentioned this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants