-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: propagate item pointermove
and click
events
#1511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
✅ Deploy Preview for eoxelements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
silvester-pari
changed the title
feat: propagate item click event
feat: propagate item pointermove and click events
Jan 31, 2025
silvester-pari
changed the title
feat: propagate item pointermove and click events
feat: propagate item Jan 31, 2025
pointermove
and click
events
StefanBrand
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks good. I've added some comments around naming of the events and testing.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented changes
This PR listens for the item pointermove and item click events inside of the Vega chart and propagates them as
pointermove.item
andclick.item
events. They do not trigger on anything else on the chart (axis, title etc.) - one can use the nativepointermove
orclick
event for that.It can be tested in the storybook by observing the console. In the bar chart example, it correctly logs the hovered and clicked bar, and if hovered/clicked above, it logs the clicked GroupItem.
Screenshots/Videos
Checklist before requesting a review