fix: support fallback for media src #1490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Changes
Problem
When uploading media using the GitHub API in git-clerk, we can only use its permanent URL. This ensures the media is always accessible, even if the branch is merged or deleted. However, the permanent URL becomes available to users only after a delay of one minute.
Solution
data-fallback-src=""
property to load the backup URL, as shown below:fallback-src
will be loaded -https://placehold.co/600x400?text=Media+not+found
Screenshots/Videos
Checklist before requesting a review