Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support emitting the drawn features in WKT and GeoJson formats #1395

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

A-Behairi
Copy link
Collaborator

@A-Behairi A-Behairi commented Nov 26, 2024

Implemented changes

Related to #1276, This Introduces a new attribute format to the drawtools, that determines the emitted format of the drawn features.

Screenshots/Videos

Checklist before requesting a review

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit 2ce6777
🔍 Latest deploy log https://app.netlify.com/sites/eoxelements/deploys/6745dfe74019620008e41ee4
😎 Deploy Preview https://deploy-preview-1395--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@A-Behairi A-Behairi requested a review from santilland November 26, 2024 14:51
Copy link
Collaborator

@silvester-pari silvester-pari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! Nice addition.

@silvester-pari silvester-pari changed the title Feat: support emitting the drawn features in WKT and GeoJson formats feat: support emitting the drawn features in WKT and GeoJson formats Nov 26, 2024
Copy link
Member

@santilland santilland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is a very practical function for the draw tools in general so someone integrating it can directly extract the information in the format needed

@silvester-pari silvester-pari merged commit d86430c into main Nov 26, 2024
7 checks passed
@silvester-pari silvester-pari deleted the drawtools/feat/return-type branch November 26, 2024 16:21
@github-actions github-actions bot mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants