Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display result image with imageProperty #1385

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

silvester-pari
Copy link
Collaborator

@silvester-pari silvester-pari commented Nov 21, 2024

Implemented changes

This PR introduces an imageProperty property, which allows (similarly to titleProperty and subTitleProperty) to define a property to render as image, both in "cards" and "list" mode.

Screenshots/Videos

"Cards" mode

image

"List" mode

image

Checklist before requesting a review

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit 10eae24
🔍 Latest deploy log https://app.netlify.com/sites/eoxelements/deploys/673f71da760c640008de4736
😎 Deploy Preview https://deploy-preview-1385--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@silvester-pari silvester-pari marked this pull request as ready for review November 21, 2024 17:26
@silvester-pari silvester-pari merged commit a269eb0 into main Nov 21, 2024
7 checks passed
@silvester-pari silvester-pari deleted the itemfilter/feat/result-image branch November 21, 2024 17:49
@github-actions github-actions bot mentioned this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant