Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Katha #1205 - mentee mentor list fix #592

Merged

Conversation

adithyadinesh0412
Copy link
Contributor

No description provided.

let extensionColumns = isAMentor ? await mentorQueries.getColumns() : await menteeQueries.getColumns()
// check for external_mentee_visibility else fetch external_mentor_visibility
extensionColumns = extensionColumns.includes('external_mentee_visibility')
? ['external_mentee_visibility', 'organization_id']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't actually added these columns to the tables right? How is this code valid if that is the case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @joffinjoy We haven't added these fields as of now.
But Akash suggested to do it this way so that once we add the fields it will work.
So here also Im checking if we have field external_mentee_visibility . If the field is present, it will take data from there else it will go with external_mentor_visibility .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @joffinjoy We haven't added these fields as of now.
But Akash suggested to do it this way so that once we add the fields it will work.
So here also Im checking if we have field external_mentee_visibility . If the field is present, it will take data from there else it will go with external_mentor_visibility .

@joffinjoy joffinjoy merged commit 86b9dc5 into ELEVATE-Project:develop Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants