Org extension create #500
Merged
Org extension create #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aks30
requested changes
Jan 22, 2024
|
|
||
| static async create(data, options = {}) { | ||
| try { | ||
| const newOrgExtension = await OrganizationExtension.create(data, options) |
There was a problem hiding this comment.
@joffinjoy why is it not consistently camel case OrganizationExtension => organizationExtension
There was a problem hiding this comment.
That is the standard that we have set for ourselves. All models will have starting letter as captials. It is the same for every other model.
|
New envs: EVENT_TYPE_CREATE='update' |
rakeshSgr
reviewed
Feb 1, 2024
|
|
||
| static async createOrgExtension(eventBody) { | ||
| try { | ||
| const extensionData = { |
There was a problem hiding this comment.
@joffinjoy can we use the eventBody Object to upsert, instead of accessing and storing the fields
rakeshSgr
reviewed
Feb 1, 2024
|
|
||
| exports.eventListenerRouter = async (eventBody, { createFn = null, updateFn = null, deleteFn = null }) => { | ||
| try { | ||
| switch (eventBody.eventType) { |
There was a problem hiding this comment.
@joffinjoy for new event type we need to upset this ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.