mentees mentors count issue #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakeshSgr
reviewed
Jan 19, 2024
| @@ -1107,9 +1108,6 @@ module.exports = class MenteesHelper { | |||
| }) | |||
| .filter((value) => value !== null) | |||
|
|
|||
| // update count after filters | |||
| userDetails.data.result.count = userDetails.data.result.count | |||
There was a problem hiding this comment.
@adithyadinesh0412 why this line removed
There was a problem hiding this comment.
userDetails already have count in it. And the count is not modified. We are using the count from userDetails.
It will be returned in the response.
joffinjoy
reviewed
Jan 19, 2024
src/middlewares/pagination.js
Outdated
| if (req.searchText != '') { | ||
| let buff = new Buffer.from(req.searchText, 'base64') | ||
| req.searchText = buff.toString('ascii') | ||
| } | ||
| let x = containsSpecialChars(req.searchText) |
There was a problem hiding this comment.
Remove this x as this is unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.