Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KATHA-2339: Changes Related To Job Scheduling #269

Merged
merged 6 commits into from
Oct 5, 2023

Conversation

VISHNUDAS-tunerlabs
Copy link
Collaborator

The PR includes changes related to KATHA-2339. You can find more details about this task at Task-2339."

### Brief of Changes:

  • Added a new API endpoint to the notification controller for elevate-scheduler service to call.
  • Safely removed three old API endpoints.
  • Implemented logic to call mentor and mentee notifications.
  • Added request module and endpoints for mentor service's communication with the scheduler service.
  • Made environmental key changes.

### .env Changes Required for Task 2339:

Two new environment keys need to be added (sample provided below):
SCHEDULER_SERVICE_HOST="http://localhost:4000/"
SCHEDULER_SERVICE_BASE_URL= '/scheduler/'

Reminder to Check: After these changes, we may no longer need migration scripts scheduler.js and bull.js. If so, we can also remove one existing .env variable, SCHEDULER_SERVICE_URL."

@joffinjoy joffinjoy changed the base branch from add-mentor-validation to develop October 3, 2023 08:58
@joffinjoy joffinjoy merged commit 50e68f5 into develop Oct 5, 2023
tech-infra pushed a commit that referenced this pull request Feb 14, 2024
different toast message when user clicks on Become a mentor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants