-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades: Ruby 3 & Rails 6 #5
Open
esoterik
wants to merge
12
commits into
master
Choose a base branch
from
ruby-3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updates Sentry client from unsupported sentry-raven to sentry-ruby, sentry-rails, sentry-delayed_job, and stackprof (for performance profiling) * Uses sentry.rb initializer from Otters, for consistency across projects * Removes any sensitive data (fields) that we were previously sending to Sentry, since data will now be a third-party service * Remove screenshotting capability - it seems this wasn't turned on before (though would be a nice feautre) and we want to limit sensitive data sent to sentry.io * Creates a custom error class to try to recreate the previous message sent to Sentry, since the new version fo the client doesn't accept the `message:` keyword
Image won't build without it matching
Update Sentry client from Raven
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.