Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: add arm64 builds to nighly #808

Merged
merged 2 commits into from
Feb 13, 2025
Merged

CI: add arm64 builds to nighly #808

merged 2 commits into from
Feb 13, 2025

Conversation

junghans
Copy link
Member

Just a start, @streeve please add some more builds

@junghans junghans requested a review from streeve February 11, 2025 18:43
@junghans junghans self-assigned this Feb 11, 2025
@junghans
Copy link
Member Author

Also check https://github.com/ECP-copa/Cabana/actions/runs/13270175348

@junghans
Copy link
Member Author

Ping @streeve

@junghans junghans marked this pull request as ready for review February 13, 2025 19:27
junghans
junghans commented Feb 13, 2025
View reviewed changes
Copy link
Member Author

@junghans junghans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and ready to merge.

@junghans
Copy link
Member Author

@dalg24-jenkins test this please

@streeve
Copy link
Member

streeve commented Feb 13, 2025

dalg24-jenkins test this please

Still not working....

@junghans
Copy link
Member Author

dalg24-jenkins test this please

Still not working....

Ok, I disabled that check for now, so you can merge this!

streeve
streeve approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@streeve streeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@streeve streeve merged commit 589068b into master Feb 13, 2025
42 checks passed
@streeve streeve deleted the ci_arm64 branch February 13, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streeve streeve streeve approved these changes

Assignees

@junghans junghans

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junghans @streeve