Merge branch 'development' into add_implicit_solver_diagnostic_file

.azure-pipelines.yml

@@ -13,6 +13,7 @@ pr:
   paths:
     exclude:
     - Docs
+    - '**/*.rst'
 
 jobs:
 - job:
@@ -65,16 +66,6 @@ jobs:
       cacheHitVar: CCACHE_CACHE_RESTORED
     displayName: Cache Ccache Objects
 
-  - task: Cache@2
-    continueOnError: true
-    inputs:
-      key: 'Python3 | "$(System.JobName)" | .azure-pipelines.yml'
-      restoreKeys: |
-         Python3 | "$(System.JobName)" | .azure-pipelines.yml
-      path: /home/vsts/.local/lib/python3.8
-      cacheHitVar: PYTHON38_CACHE_RESTORED
-    displayName: Cache Python Libraries
-
   - bash: |
       set -o nounset errexit pipefail
       cat /proc/cpuinfo | grep "model name" | sort -u
@@ -140,7 +131,7 @@ jobs:
       df -h
       # configure
       export AMReX_CMAKE_FLAGS="-DAMReX_ASSERTIONS=ON -DAMReX_TESTING=ON"
-      export WARPX_TEST_FLAGS="-DWarpX_TEST_CLEANUP=ON -DWarpX_TEST_FPETRAP=ON -DWarpX_TEST_DEBUG=ON"
+      export WARPX_TEST_FLAGS="-DWarpX_TEST_CLEANUP=ON -DWarpX_TEST_FPETRAP=ON -DWarpX_BACKTRACE_INFO=ON"
       cmake -S . -B build    \
         ${AMReX_CMAKE_FLAGS} \
         ${WARPX_CMAKE_FLAGS} \
@@ -154,8 +145,16 @@ jobs:
   - bash: |
       # set options
       set -o nounset errexit pipefail
-      # run tests (exclude pytest.AMReX when running Python tests)
-      ctest --test-dir build --output-on-failure -E AMReX
+      # determine if the build was triggered by a push to the development branch
+      if [[ "$(Build.SourceBranch)" == "refs/heads/development" ]]; then
+        # run tests (exclude pytest.AMReX when running Python tests)
+        # and submit results to CDash as Experimental
+        ctest --test-dir build --output-on-failure -E AMReX \
+          -D ExperimentalTest -D ExperimentalSubmit
+      else
+        # run tests (exclude pytest.AMReX when running Python tests)
+        ctest --test-dir build --output-on-failure -E AMReX
+      fi
     displayName: 'Test'
 
   - bash: |
@@ -167,3 +166,9 @@ jobs:
         -exec cat {} \;
     displayName: 'Logs'
     condition: always()
+
+  - bash: |
+      # clean out so the Post-job Cache "tar" command has more disk space available
+      rm -rf build
+    displayName: 'Clean Build Directory'
+    condition: always()

.clang-tidy

@@ -19,6 +19,7 @@ Checks: '
         -cppcoreguidelines-avoid-non-const-global-variables,
         -cppcoreguidelines-init-variables,
         -cppcoreguidelines-macro-usage,
+        -cppcoreguidelines-missing-std-forward,
         -cppcoreguidelines-narrowing-conversions,
         -cppcoreguidelines-non-private-member-variables-in-classes,
         -cppcoreguidelines-owning-memory,
@@ -29,6 +30,7 @@ Checks: '
     misc-*,
         -misc-no-recursion,
         -misc-non-private-member-variables-in-classes,
+        -misc-include-cleaner,
     modernize-*,
         -modernize-avoid-c-arrays,
         -modernize-return-braced-init-list,
@@ -55,6 +57,9 @@ CheckOptions:
   value:        "H,"
 - key:          modernize-pass-by-value.ValuesOnly
   value:        "true"
-
+- key:          misc-use-anonymous-namespace.HeaderFileExtensions
+  value:        "H,"
+- key:          performance-move-const-arg.CheckTriviallyCopyableMove
+  value:        "false"
 
 HeaderFilterRegex: 'Source[a-z_A-Z0-9\/]+\.H$'

.github/ISSUE_TEMPLATE/blank_issue.md

@@ -0,0 +1,14 @@
+---
+name: Blank issue
+about: Ask us a question
+labels: [question]
+---
+
+Are you here because you have something to report that is neither a bug, a new feature, nor an installation problem?
+
+Before opening this issue, consider opening a [discussion](https://github.com/ECP-WarpX/WarpX/discussions) instead!
+
+Issues are used to report bugs, installation problems or to request new features.
+Discussions are used to ask more open-ended questions, brainstorm, ask our feedback, etc.
+
+You can find more details on how to use issues and discussions [here](https://github.com/ECP-WarpX/WarpX/blob/development/CONTRIBUTING.rst).

.github/ISSUE_TEMPLATE/config.yml

@@ -1 +1 @@
-blank_issues_enabled: true
+blank_issues_enabled: false

.github/workflows/clang_sanitizers.yml

@@ -7,6 +7,7 @@ on:
   pull_request:
     paths-ignore:
       - "Docs/**"
+      - "**.rst"
 
 concurrency:
   group: ${{ github.ref }}-${{ github.head_ref }}-clangsanitizers
@@ -15,8 +16,7 @@ concurrency:
 jobs:
   build_UB_sanitizer:
     name: Clang UB sanitizer
-    runs-on: ubuntu-22.04
-    container: ubuntu:23.10
+    runs-on: ubuntu-24.04
     if: github.event.pull_request.draft == false
     env:
       CC: clang
@@ -27,7 +27,7 @@ jobs:
     - uses: actions/checkout@v4
     - name: install dependencies
       run: |
-        .github/workflows/dependencies/clang17.sh
+        .github/workflows/dependencies/clang.sh 17
     - name: CCache Cache
       uses: actions/cache@v4
       with:
@@ -65,10 +65,6 @@ jobs:
     - name: run with UB sanitizer
       run: |
 
-        # We need these two lines because these tests run inside a docker container
-        export OMPI_ALLOW_RUN_AS_ROOT=1
-        export OMPI_ALLOW_RUN_AS_ROOT_CONFIRM=1
-
         export OMP_NUM_THREADS=2
 
         #MPI implementations often leak memory
@@ -81,9 +77,9 @@ jobs:
 
   build_thread_sanitizer:
     name: Clang thread sanitizer
-    runs-on: ubuntu-22.04
-    container: ubuntu:23.10
-    if: github.event.pull_request.draft == false
+    runs-on: ubuntu-24.04
+    # TODO Fix data race conditions and re-enable job
+    if: 0 #github.event.pull_request.draft == false
     env:
       CC: clang
       CXX: clang++
@@ -93,7 +89,7 @@ jobs:
     - uses: actions/checkout@v4
     - name: install dependencies
       run: |
-        .github/workflows/dependencies/clang17.sh
+        .github/workflows/dependencies/clang.sh 17
     - name: CCache Cache
       uses: actions/cache@v4
       with:
@@ -149,10 +145,6 @@ jobs:
         export TSAN_OPTIONS='ignore_noninstrumented_modules=1'
         export ARCHER_OPTIONS="verbose=1"
 
-        # We need these two lines because these tests run inside a docker container
-        export OMPI_ALLOW_RUN_AS_ROOT=1
-        export OMPI_ALLOW_RUN_AS_ROOT_CONFIRM=1
-
         export OMP_NUM_THREADS=2
 
         mpirun -n 2 ./build/bin/warpx.rz Examples/Physics_applications/laser_acceleration/inputs_base_rz warpx.serialize_initial_conditions = 0

.github/workflows/clang_tidy.yml

@@ -7,6 +7,7 @@ on:
   pull_request:
     paths-ignore:
       - "Docs/**"
+      - "**.rst"
 
 concurrency:
   group: ${{ github.ref }}-${{ github.head_ref }}-clangtidy
@@ -19,13 +20,13 @@ jobs:
         dim: [1, 2, RZ, 3]
     name: clang-tidy-${{ matrix.dim }}D
     runs-on: ubuntu-22.04
-    timeout-minutes: 180
+    timeout-minutes: 250
     if: github.event.pull_request.draft == false
     steps:
     - uses: actions/checkout@v4
     - name: install dependencies
       run: |
-        .github/workflows/dependencies/clang15.sh
+        .github/workflows/dependencies/clang.sh 17
     - name: set up cache
       uses: actions/cache@v4
       with:
@@ -42,8 +43,8 @@ jobs:
         export CCACHE_LOGFILE=${{ github.workspace }}/ccache.log.txt
         ccache -z
 
-        export CXX=$(which clang++-15)
-        export CC=$(which clang-15)
+        export CXX=$(which clang++-17)
+        export CC=$(which clang-17)
 
         cmake -S . -B build_clang_tidy      \
           -DCMAKE_VERBOSE_MAKEFILE=ON       \
@@ -61,7 +62,7 @@ jobs:
 
         ${{github.workspace}}/.github/workflows/source/makeMakefileForClangTidy.py --input ${{github.workspace}}/ccache.log.txt
         make -j4 --keep-going -f clang-tidy-ccache-misses.mak \
-            CLANG_TIDY=clang-tidy-15 \
+            CLANG_TIDY=clang-tidy-17 \
             CLANG_TIDY_ARGS="--config-file=${{github.workspace}}/.clang-tidy --warnings-as-errors=*"
 
         ccache -s

.github/workflows/cuda.yml

@@ -7,6 +7,7 @@ on:
   pull_request:
     paths-ignore:
       - "Docs/**"
+      - "**.rst"
 
 concurrency:
   group: ${{ github.ref }}-${{ github.head_ref }}-cuda
@@ -55,7 +56,7 @@ jobs:
         which nvcc || echo "nvcc not in PATH!"
 
         cmake-easyinstall --prefix=/usr/local \
-          git+https://github.com/openPMD/openPMD-api.git@0.15.1 \
+          git+https://github.com/openPMD/openPMD-api.git@0.16.1 \
           -DopenPMD_USE_PYTHON=OFF    \
           -DBUILD_TESTING=OFF         \
           -DBUILD_EXAMPLES=OFF        \
@@ -126,7 +127,7 @@ jobs:
         which nvcc || echo "nvcc not in PATH!"
 
         git clone https://github.com/AMReX-Codes/amrex.git ../amrex
-        cd ../amrex && git checkout --detach 456c93c7d9512f1cdffac0574973d7df41417898 && cd -
+        cd ../amrex && git checkout --detach 044d52f7d309e340939d7cae449fd83209da317f && cd -
         make COMP=gcc QED=FALSE USE_MPI=TRUE USE_GPU=TRUE USE_OMP=FALSE USE_FFT=TRUE USE_CCACHE=TRUE -j 4
 
         ccache -s

.github/workflows/dependencies/clang17.sh → .github/workflows/dependencies/clang.sh

@@ -1,50 +1,50 @@
 #!/usr/bin/env bash
 #
-# Copyright 2024 The WarpX Community
+# Copyright 2025 The WarpX Community
 #
 # License: BSD-3-Clause-LBNL
-# Authors: Luca Fedeli
 
 set -eu -o pipefail
 
-# This dependency file is currently used within a docker container,
-# which does not come with sudo.
-apt-get -qqq update
-apt-get -y install sudo
-
-# `man apt.conf`:
-#   Number of retries to perform. If this is non-zero APT will retry
-#   failed files the given number of times.
+# `man apt.conf`: number of retries to perform (if non-zero,
+# APT will retry failed files the given number of times).
 echo 'Acquire::Retries "3";' | sudo tee /etc/apt/apt.conf.d/80-retries
 
-# This dependency file is currently used within a docker container,
-# which does not come (among others) with wget, xz-utils, curl, git,
-# ccache, and pkg-config pre-installed.
-sudo apt-get -qqq update
+sudo apt-get update
 sudo apt-get install -y \
     cmake               \
-    clang-17            \
-    clang-tidy-17       \
     libblas-dev         \
-    libc++-17-dev       \
     libboost-math-dev   \
     libfftw3-dev        \
     libfftw3-mpi-dev    \
     libhdf5-openmpi-dev \
     liblapack-dev       \
     libopenmpi-dev      \
-    libomp-17-dev       \
-    ninja-build         \
-    wget                \
-    xz-utils            \
-    curl                \
-    git                 \
-    ccache              \
-    pkg-config
+    ninja-build
+
+# parse clang version number from command line
+version_number=${1}
+
+# add LLVM repository and install clang tools
+wget https://apt.llvm.org/llvm.sh
+chmod +x llvm.sh
+sudo ./llvm.sh ${version_number}
+
+# install clang, clang-tidy, and
+# LLVM implementations of C++ standard library and OpenMP
+sudo apt-get update
+sudo apt-get install -y          \
+    clang-${version_number}      \
+    clang-tidy-${version_number} \
+    libc++-${version_number}-dev \
+    libomp-${version_number}-dev
+
+# export compiler flags
+export CXX=$(which clang++-${version_number})
+export CC=$(which clang-${version_number})
 
-# Use clang 17
-export CXX=$(which clang++-17)
-export CC=$(which clang-17)
+# ccache
+$(dirname "$0")/ccache.sh
 
 # cmake-easyinstall
 #

.github/workflows/dependencies/hip.sh

@@ -53,6 +53,7 @@ sudo apt-get install -y --no-install-recommends \
     rocm-dev        \
     rocfft-dev      \
     rocprim-dev     \
+    rocsparse-dev   \
     rocrand-dev     \
     hiprand-dev