Golaz1/2.1.0 misc fixes #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing bundling to fail when no [ilamb_run] task was present.
forsyth2
approved these changes
Jun 21, 2022
|
|
||
| year1 = y | ||
| year2 = y + 10 - 1 | ||
| year2 = y + ts_num_years - 1 |
There was a problem hiding this comment.
Note: the number of years still has to be divisible by the increment.
| @@ -28,7 +28,7 @@ def ilamb_run(config, scriptDir, existing_bundles): | |||
| # --- List of ilamb_run tasks --- | |||
| tasks = getTasks(config, "ilamb_run") | |||
| if len(tasks) == 0: | |||
| return [] | |||
| return existing_bundles | |||
There was a problem hiding this comment.
This was already fixed in #265.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc minor fixes found while testing E3SM Unified 1.7.0rc1 on NERSC Cori-haswell.
Currently running additional tests, but those fixes should go in before the next unified rc.