Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit Core/24.00 module to crayclang-scream for Frontier. #3029

Merged

Conversation

trey-ornl
Copy link
Contributor

OLCF plans to switch defaults for module Core from 24.00 to 24.07. The newer module has a newer version of cmake, and not cmake/3.21.3. The newer cmake is apparently confused by the older style of handling the Cray and AMD compilers. This pull request adds explicit loading of the soon-to-be-previous-default module, Core/24.00, for Frontier build with crayclang-scream. I also changed the version of libunwind to one that is actually available. I think the previous builds quietly failed to load it.

I confirmed that the newer software stack, represented by compiler craygnuamdgpu, works with Core/24.07, so I made no changes to that config.

As an aside, I recommend that all new E3SM runs on Frontier move to craygnuamdgpu.

@E3SM-Bot
Copy link
Collaborator

E3SM-Bot commented Oct 4, 2024

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@AaronDonahue AaronDonahue requested review from ambrad and brhillman and removed request for ambrad and brhillman October 7, 2024 23:04
@AaronDonahue
Copy link
Contributor

@ambrad , would you be comfortable reviewing this PR? I believe you reviewed the last frontier machine file change right?

@AaronDonahue AaronDonahue added Machine File CI: skip eamxx-sa Skip eamxx standalone testing for this PR CI: skip eamxx-v1 Skip eamxx CIME testing for this PR labels Oct 7, 2024
@AaronDonahue
Copy link
Contributor

Adding the skip-testing labels since we don't test on frontier w/ the AT. @trey-ornl already confirmed that this change works on frontier.

@E3SM-Bot
Copy link
Collaborator

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

@ambrad ambrad merged commit 0422f57 into E3SM-Project:master Oct 11, 2024
3 of 4 checks passed
brhillman pushed a commit that referenced this pull request Oct 22, 2024
Add explicit Core/24.00 module to crayclang-scream for Frontier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: skip eamxx-sa Skip eamxx standalone testing for this PR CI: skip eamxx-v1 Skip eamxx CIME testing for this PR Machine File
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants