For pm-gpu: use small kernels as default for shoc/p3 #7099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndkeen
added
Machine Files
Performance
pm-gpu
mahf708
reviewed
Mar 7, 2025
|
doh! Yep, I was testing with it ON/OFF, and committed before turning it back ON. Fixed. |
mahf708
approved these changes
Mar 7, 2025
bartgol
approved these changes
Mar 8, 2025
ndkeen
added a commit
that referenced
this pull request
Mar 8, 2025
…o next (PR #7099) For pm-gpu, we see the small kernel path (SMALL_KERNELS) performing faster in all situations. Also BFB with monolithic kernels. Currently, this only impacts SHOC/P3. [bfb]
|
merged to next. Late Friday, but what's the worst that could happen? |
|
Noting that with daily testing, all of the non-DEBUG cases are BFB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For pm-gpu, we see the small kernel path (SMALL_KERNELS) performing faster in all situations.
Also BFB with monolithic kernels.
Currently, this only impacts SHOC/P3.
[bfb]