-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#9 회원 탈퇴 구현 #13
Open
tpleehan
wants to merge
8
commits into
develop
Choose a base branch
from
feature/9-withdrawal
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
#9 회원 탈퇴 구현 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lob-dev
approved these changes
Apr 23, 2023
src/main/java/com/project/lala/controller/MemberController.java
Outdated
Show resolved
Hide resolved
- Test class에서 Service Bean 의존성 주입이 되지 않은 에러 발생으로 수정
Q : 보유 기간이 만료될 경우 회원 정보를 파기해야 할 때, 스케줄링을 사용해서 만료 기간에 파기할 수 있도록 구현하는 방법이 있는데 혹시 스케줄링 이외에 다른 방법이 있는지 궁금합니다 ! A : 개인적으로 스케줄링은 "어떤 시기에 어떤 일을 한다"라는 의미를 가진다고 봅니다. "사용자의 보유 기간이 만료되었다"라는 이벤트를 실시간으로 전파할 수 없다면 스케줄링을 기반으로 하는 데이터 탐색 행위가 수행되어야 합니다.
그리고 "어떤 일을 한다"에 해당하는 부분은 구현 편의성과 일별 데이터 적재량 등의 요소를 고려하여 선택할 수 있습니다. |
Lob-dev
approved these changes
May 2, 2023
- session, 정규표현식 추가 및 test code 부분 수정
- session 대신 아이디를 사용하는 방식으로 수정
- url 노출에 대한 보안 취약점 수정
Lob-dev
reviewed
May 27, 2023
src/main/java/com/project/lala/controller/MemberController.java
Outdated
Show resolved
Hide resolved
- session null check, 변수명 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9 회원 탈퇴 구현
Description 📝
To Reviewers 🙋