GLThread with a separate hidden window #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanCope
reviewed
Dec 4, 2023
| initialise(); | ||
| } | ||
| } | ||
| glThread.execute(() -> { |
There was a problem hiding this comment.
What happens if the thread is already executing at this point? Or is it blocking?
There was a problem hiding this comment.
Yea it's blocking, the part that makes it so is the futureTask.get() : https://github.com/DylanCope/ProtoEvo/pull/3/files#diff-beeefb6e46276d407fd4189b5cc69e6a39f56f546f34626f9f11c782a2fadf29R34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run GLComputeShaderRunner tasks in a separate thread that has a different opengl context. A new hidden window is used as the context. Removes the need to rely on ApplicationManager window and since the hidden window is not destroyed when switching to terminal only mode, the GLSL shader runs fine even if libgdx app has been exited.