-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Axum routes migration #577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mental32
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good to me, one comment however.
vgarleanu
requested changes
Nov 15, 2023
I believe I've addressed all of the feedback now. Let me know if I missed anything. |
vgarleanu
approved these changes
Nov 21, 2023
niamu
added a commit
to niamu/dim
that referenced
this pull request
Nov 22, 2023
* Migrate dashboard routes to Axum * Migrate tv/season/episode routes to Axum * Migrate filebrowser routes to Axum * Do not attempt to extract user in TV routes where it is unused * Library routes moved to be within auth middleware * Migrate search route to Axum * Migrate settings routes to Axum * Migrate mediafile routes to Axum * Migrate user routes to Axum * Migrate media routes to Axum * Move media_routes within Axum auth middleware * Cleanup imports and move to displaydoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing to chip away at #548
The
/
,/static
,/images
, and/api/v1/stream/*path
routes are not included in this PR, but I believe everything else is covered.Apologies in advance for not separating each of these route sections into their own PR. I did make an effort to break it up commit by commit though so hopefully the review isn't too arduous.