Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axum routes migration #577

Merged
merged 12 commits into from
Nov 21, 2023
Merged

Axum routes migration #577

merged 12 commits into from
Nov 21, 2023

Conversation

niamu
Copy link
Contributor

@niamu niamu commented Nov 14, 2023

Continuing to chip away at #548

The /, /static, /images, and /api/v1/stream/*path routes are not included in this PR, but I believe everything else is covered.

Apologies in advance for not separating each of these route sections into their own PR. I did make an effort to break it up commit by commit though so hopefully the review isn't too arduous.

Copy link
Collaborator

@mental32 mental32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me, one comment however.

@niamu
Copy link
Contributor Author

niamu commented Nov 16, 2023

I believe I've addressed all of the feedback now. Let me know if I missed anything.

@niamu niamu requested a review from vgarleanu November 20, 2023 07:47
@vgarleanu vgarleanu merged commit af6df1c into Dusk-Labs:master Nov 21, 2023
niamu added a commit to niamu/dim that referenced this pull request Nov 22, 2023
* Migrate dashboard routes to Axum

* Migrate tv/season/episode routes to Axum

* Migrate filebrowser routes to Axum

* Do not attempt to extract user in TV routes where it is unused

* Library routes moved to be within auth middleware

* Migrate search route to Axum

* Migrate settings routes to Axum

* Migrate mediafile routes to Axum

* Migrate user routes to Axum

* Migrate media routes to Axum

* Move media_routes within Axum auth middleware

* Cleanup imports and move to displaydoc
@niamu niamu deleted the axum_routes branch November 27, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants