-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show event link #685
show event link #685
Conversation
The code looks good(!), but do we want the link to only display the text "link", or should it display the href to make it obvious where it links to? The positions spells it out instead of linking to google maps and displaying something like "position". Is this something we want to do or would that be too much information? Could perhaps truncate long links when displayed to avoid ugly overflow then. |
maybe DWWW-ansvarig @Isak-Kallini should have the final opinion? |
I think either can work, what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but conflicts need to be resolved
3808be3
to
808ef91
Compare
closes #684