Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show event link #685

Merged
merged 2 commits into from
Jan 29, 2025
Merged

show event link #685

merged 2 commits into from
Jan 29, 2025

Conversation

anahitachavan
Copy link
Contributor

closes #684

@stagrim
Copy link
Contributor

stagrim commented Jan 20, 2025

The code looks good(!), but do we want the link to only display the text "link", or should it display the href to make it obvious where it links to? The positions spells it out instead of linking to google maps and displaying something like "position". Is this something we want to do or would that be too much information? Could perhaps truncate long links when displayed to avoid ugly overflow then.

@anahitachavan
Copy link
Contributor Author

The code looks good(!), but do we want the link to only display the text "link", or should it display the href to make it obvious where it links to? The positions spells it out instead of linking to google maps and displaying something like "position". Is this something we want to do or would that be too much information? Could perhaps truncate long links when displayed to avoid ugly overflow then.

maybe DWWW-ansvarig @Isak-Kallini should have the final opinion?

@Isak-Kallini
Copy link
Member

maybe DWWW-ansvarig @Isak-Kallini should have the final opinion?

I think either can work, what do you think?

Copy link
Contributor

@stagrim stagrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@Isak-Kallini Isak-Kallini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but conflicts need to be resolved

@Isak-Kallini Isak-Kallini merged commit 8f77723 into Dsek-LTH:main Jan 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show link in event
3 participants