Skip to content

Upgrade to Svelte 5 again #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 14, 2025
Merged

Upgrade to Svelte 5 again #626

merged 12 commits into from
Apr 14, 2025

Conversation

danieladugyan
Copy link
Member

@danieladugyan danieladugyan commented Dec 5, 2024

TO-DO: Test that the page still works!

#592 broke some forms so it has been temporarily reverted. The changes are kept on this branch so that they can be merged again once the issues are resolved.

This reverts commit ca2f7e8.
@Isak-Kallini
Copy link
Member

I've clicked around and tried most forms and it seems to be working now, it's very possible that I've missed something so it would be good if someone else clicked around a bit as well

@Isak-Kallini Isak-Kallini requested a review from stagrim March 25, 2025 15:31
@danieladugyan danieladugyan moved this from 🆕 New to 🎯 Todo in CPU Apr 14, 2025
@danieladugyan danieladugyan requested review from o-korpi and removed request for stagrim April 14, 2025 15:10
@Isak-Kallini Isak-Kallini moved this from 🎯 Todo to 📝In review in CPU Apr 14, 2025
Copy link
Contributor

@o-korpi o-korpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍
Tried most forms I could find, nothing appears to be broken.

@o-korpi o-korpi merged commit 1f26093 into main Apr 14, 2025
3 of 5 checks passed
@o-korpi o-korpi deleted the svelte-5 branch April 14, 2025 16:46
@github-project-automation github-project-automation bot moved this from 📝In review to ✅ Done in CPU Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants