New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make methods protected for subclassability #17

Merged

will-in-wi merged 1 commit into master from 16-make-methods-protected

Jul 26, 2018

Contributor

will-in-wi commented Jul 26, 2018

Fixes #16

Good point about best practice being to mark as protected, unless you are explicitly trying to make some kind of inheritance API, which we aren't.

To be clear, no guarantee is being made about the stability of the protected methods, they can be refactored and changed at any time.


          Make methods protected for subclassability. Fixes #16

d2faf03

will-in-wi self-assigned this

will-in-wi merged commit 778ac4e into master

will-in-wi deleted the 16-make-methods-protected branch

July 26, 2018 15:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet