Add create_or_update_subscribers method #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the submission! I'm going to see if I can get another pair of eyes on this internally, then assuming there are no issues, I'll merge and push it out. |
will-in-wi
suggested changes
Jul 19, 2018
src/Client.php
Outdated
| * @param array $params | ||
| * @return \Drip\ResponseInterface | ||
| */ | ||
| public function create_or_update_subscriber_batch($params) |
There was a problem hiding this comment.
Looking at this again, could we change the name of this method to create_or_update_subscribers to match the Ruby client? https://github.com/DripEmail/drip-ruby/blob/master/lib/drip/client/subscribers.rb#L67
Thanks!
j831
force-pushed
the
add-create_or_update_subscriber_batch-method
branch
from
7e12b91 to
858dd09
Compare
|
I renamed the method, thanks for the quick feedback. |
will-in-wi
approved these changes
Jul 19, 2018
j831
changed the title
|
This just got released in 1.1.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the Drip REST API batch endpoint to update up to 1000 subscribers at a time.
http://developer.drip.com/#batch-api