Test that a 400 or 500 response is not a success

Specifically this should not throw an exception
DripEmail · Aug 8, 2018 · b61c24a · b61c24a
1 parent 3154756
commit b61c24a
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/Client.php b/src/Client.php
@@ -337,6 +337,7 @@ protected function make_request($url, $params = array(), $req_method = self::GET
                 'Accept' => 'application/json, text/javascript, */*; q=0.01',
                 'Content-Type' => 'application/vnd.api+json',
             ],
+            'http_errors' => false,
         ];
 
         switch ($req_method) {

diff --git a/tests/ClientTest.php b/tests/ClientTest.php
@@ -29,6 +29,22 @@ public function testInvalidAccountId()
         new \Drip\Client("abc123", "");
     }
 
+    public function testErrorResponseReturned()
+    {
+        $mocked_requests = [];
+        $client = GuzzleHelpers::mocked_client($mocked_requests, [
+            // default client request option "http_errors" will throw
+            // GuzzleHttp\Exception\ClientException but we set it false so
+            // no exception is thrown.
+            new Response(401, [], '{"error":"hello"}'),
+            new Response(502, [], 'timeout'),
+        ]);
+        $response401 = $client->fetch_campaign(['campaign_id' => 1]);
+        $this->assertFalse($response401->is_success());
+        $response502 = $client->fetch_campaign(['campaign_id' => 1]);
+        $this->assertFalse($response502->is_success());
+    }
+
     ////////////////////////// C A M P A I G N S //////////////////////////
 
     // #get_campaigns