Make it work :) #20
Make it work :) #20
Conversation
|
Here's a build for those interested: https://github.com/Minishlink/GifHub/releases/tag/v1.0.9 |
src/js/sites/GitHub/api.js
Outdated
| downsizedUri: imgs.get(1).src | ||
| }; | ||
| }); | ||
| const $res = $(res); |
There was a problem hiding this comment.
Would you mind fixing the indentation here to 4 spaces to match the rest of the file? 😃
|
Thanks for doing this! I haven't used the extension in awhile, so I didn't notice! Happy to merge/release once you fix the super tiny nit I left about spacing. |
| @@ -17,6 +17,6 @@ | |||
| ], | |||
| "background": { | |||
| "scripts": ["background.js"], | |||
| "peristent": false | |||
| "persistent": false | |||
There was a problem hiding this comment.
Ha! Can't believe I missed that 😆. Nice catch
|
You're very welcome, thanks for the extension! |
|
Thanks for the great extension @DrewML 👍 it would be great to get this PR merged and update the version of the extension on the Chrome store as it is currently not working anymore. |
|
Are there anything we can do to help getting this PR merged? |
|
@Minishlink @DrewML awesome work. Could you merge and update the version on the extension store? |
|
merge + 1 |
|
@DrewML Any possibility of merging this? |
|
Yeah, merge this! :) |
|
Another ping after 1 yr and a half of waiting your merge lol 🙄 |
Hi,
The extension is not working anymore as-is. I put some fixes here.