Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FlyoutPage to use content properties #26

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Update FlyoutPage to use content properties #26

merged 3 commits into from
Jun 29, 2022

Conversation

Dreamescaper
Copy link
Owner

@Dreamescaper Dreamescaper commented Jun 24, 2022 •
edited
Loading

Fixes #23 .

@Dreamescaper
Copy link
Owner Author

@AmirImam
I have update FlyoutPage to accept pages in Flyout / Detail properties.
I've also added FlyoutPageSample to the solution.
Would you be able to check this sample whether it makes sense for you before I merge it?

@AmirImam
Copy link

@AmirImam I have update FlyoutPage to accept pages in Flyout / Detail properties. I've also added FlyoutPageSample to the solution. Would you be able to check this sample whether it makes sense for you before I merge it?

Yes it works, but without navigation. I mean in application startup it shows first page (ContactsPage), but when I click on any (FlyoutMenuItem) it shows blank white page. But in generally now I can make the FlyoutPage is the app's MainPage

@Dreamescaper
Copy link
Owner Author

@AmirImam
Yep, there was a small bug which caused an empty page in some cases, thanks a lot!
It should be fixed now.

@Dreamescaper Dreamescaper merged commit 1eaf4e2 into main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to use FlyoutPage instead of Shell
2 participants
@Dreamescaper @AmirImam