Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.19 update #19

Closed
wants to merge 9 commits into from
Closed

1.19 update #19

wants to merge 9 commits into from

Conversation

Luligabi1
Copy link
Contributor

@Luligabi1 Luligabi1 commented Jun 3, 2022

1.19's update process is much more difficult than usual due to the issue I described in #18 . To address said issues, I've decided to take @alkyaly 's #14 and update it to 1.19, alongside some improvements:

Despite the big changes, 1.2.3 and lower configs will still work as expected.

The testmod is once again updated.

@Luligabi1
Copy link
Contributor Author

Hey @Draylar, how you're doing? Would you mind me doing a fork of Omega Config including my PR (and jij-ing it) until you have the time to merge it or giving me write access to this repo? One way or another many of my mods depend on OmegaConfig to be updated and I'd like to update them asap 😅

@tennox
Copy link

tennox commented Jul 25, 2022

@Luligabi1 you opted to write your own instead? 😅 😢

No offense, just wondering how I can avoid that

@Draylar
Copy link
Owner

Draylar commented Jul 26, 2022

Whoops, totally missed your last comment (thanks for the notification @ tennox), super sorry about the delay Luli. I'm currently still on 1.18.2 for my non-public/prioritized projects and haven't had time to review this PR, but you are more than welcome to do anything you need to ship a separate fork of Omega Config in the meantime - feel free to JIJ your custom version, post a separate CF/GH page, etc.

I'll put a big sticky note on my desk to remind me to look into this in the next few days. At an initial glance, I think I might look into porting Cloth Config Lite up - love the builder syntax for fine-tuned control, but I also need the no-hassle auto-screen-generation shedaniel wrote. Will get back to you in a few days.

(* side note for viewers - main/core library from 1.18.2 still works fine on 1.19, the only thing that broke for 1.19 is the GUI module.)

@Luligabi1
Copy link
Contributor Author

Luligabi1 commented Jul 28, 2022

Whoops, totally missed your last comment (thanks for the notification @ tennox), super sorry about the delay Luli. I'm currently still on 1.18.2 for my non-public/prioritized projects and haven't had time to review this PR, but you are more than welcome to do anything you need to ship a separate fork of Omega Config in the meantime - feel free to JIJ your custom version, post a separate CF/GH page, etc.

Thank you.

I'll put a big sticky note on my desk to remind me to look into this in the next few days. At an initial glance, I think I might look into porting Cloth Config Lite up - love the builder syntax for fine-tuned control, but I also need the no-hassle auto-screen-generation shedaniel wrote. Will get back to you in a few days.

The base of this rewrite is Cloth Config Lite, but all inside Omega Config Gui, since shedaniel doesn't plan to maintain CCL as a separete project anymore. I don't think it's necessary to maintain CCL separetely (unless you need it for something else) given how the "no-hassle auto-screen-generation " is still here by default, and anyone upgrading directly from 1.18 and lower doesn't need to do any changes. What could be made is creating a non-deprecated version of registerConfigScreen (something like registerSimpleConfigScreen?) so it's clear registerConfigScreen is kept around for easier upgrading, but it's not the main thing anymore. Would that be good to you?

@Luligabi1
Copy link
Contributor Author

It has come to my attention there's some scrollbar issues (not appearing when they should or straight up not scrolling). I'll try to fix this in the next few days, but I can't promise much :/

@Luligabi1
Copy link
Contributor Author

I've had a change of heart and no longer plan to update this PR. If someone wants to attempt to fix it, I'll keep the fork for now. Biggest issues atm are:

  • Scrollbar does not work, buttons overlap with the Cancel/Done buttons;
  • Enums are not supported.

@Luligabi1 Luligabi1 closed this Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OmegaConfigGui config screen doesn't use translations
3 participants