Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior of SA1009 for closing parenthesis before binary operator #2411

Merged
merged 2 commits into from
Jun 15, 2017

Conversation

sharwell
Copy link
Member

Fixes #2409

@codecov
Copy link

codecov bot commented Jun 15, 2017

Codecov Report

Merging #2411 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2411      +/-   ##
==========================================
+ Coverage   96.44%   96.45%   +0.01%     
==========================================
  Files         714      714              
  Lines       92509    92517       +8     
  Branches     3443     3443              
==========================================
+ Hits        89216    89240      +24     
+ Misses       2401     2385      -16     
  Partials      892      892
Impacted Files Coverage Δ
...Cop.Analyzers.Test/SpacingRules/SA1009UnitTests.cs 100% <100%> (ø) ⬆️
...s/SA1009ClosingParenthesisMustBeSpacedCorrectly.cs 100% <100%> (ø) ⬆️
...eCop.Analyzers/Helpers/ObjectPools/ObjectPool`1.cs 87.03% <0%> (+29.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca4acb4...b8d237b. Read the comment docs.

@sharwell sharwell merged commit 9849873 into DotNetAnalyzers:master Jun 15, 2017
@sharwell sharwell deleted the fix-sa1009-operators branch June 15, 2017 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant