Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using CodeFixValidationMode.None in tests #2785

Closed
sharwell opened this issue Sep 11, 2018 · 0 comments · Fixed by #3753
Closed

Avoid using CodeFixValidationMode.None in tests #2785

sharwell opened this issue Sep 11, 2018 · 0 comments · Fixed by #3753
Labels
bug fixed
Milestone
1.2.0-beta.553

Comments

@sharwell
Copy link
Member

sharwell commented Sep 11, 2018 •
edited
Loading

🔗 Issue filed in response to #2751 (comment)

  • Tests should validate the semantic structure by default
  • The few tests which fail validation should be updated to pass semantic structure validation or use a localized configuration of CodeFixValidationMode.None
@sharwell sharwell added the bug label Sep 11, 2018
@sharwell sharwell mentioned this issue Sep 11, 2018
Merged
bjornhellander added a commit to bjornhellander/StyleCopAnalyzers that referenced this issue Dec 17, 2023
@bjornhellander
Change default value of test property CodeActionValidationMode to Sem…
43d80d9 
…anticStructure instead of None and update so that tests still pass

DotNetAnalyzers#2785
@bjornhellander bjornhellander mentioned this issue Dec 17, 2023
Merged
bjornhellander added a commit to bjornhellander/StyleCopAnalyzers that referenced this issue Dec 18, 2023
@bjornhellander
Change default value of test property CodeActionValidationMode to Sem…
e004d41 
…anticStructure instead of None and update so that tests still pass

DotNetAnalyzers#2785
@sharwell sharwell added this to the 1.2-beta.next milestone Dec 19, 2023
@sharwell sharwell added the fixed label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed
Projects
None yet
Milestone
1.2.0-beta.553
1 participant
@sharwell