Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA1025 should ignore trailing spaces #1245

Closed
Maxwe11 opened this issue Aug 19, 2015 · 4 comments
Closed

SA1025 should ignore trailing spaces #1245

Maxwe11 opened this issue Aug 19, 2015 · 4 comments
Assignees
Milestone

Comments

@Maxwe11
Copy link
Member

Maxwe11 commented Aug 19, 2015

    public class FooBar
    {.......

Dots - trailing spaces.

Actual report

  • SA1025 (CodeMustNotContainMultipleWhitespaceInARow)
  • SA1028 (CodeMustNotContainTrailingWhitespace)

Expected report

  • SA1028 (CodeMustNotContainTrailingWhitespace)
@sharwell
Copy link
Member

💭 I think we should update SA1025 to never be reported for trailing spaces, regardless of whether or not SA1028 is enabled.

@Maxwe11
Copy link
Member Author

Maxwe11 commented Aug 19, 2015

I think we should update SA1025 to never be reported for trailing spaces, regardless of whether or not SA1028 is enabled.

I meant that 😄

@sharwell
Copy link
Member

I clarified it, because some of our diagnostics actually conditionally report warnings when other rules are suppressed.

@sharwell sharwell changed the title SA1025 should be suppressed by SA1028 with trailing spaces SA1025 should ignore trailing spaces Aug 20, 2015
@pdelvo
Copy link
Member

pdelvo commented Aug 21, 2015

grabbed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants