Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Permanently disable rule SA1409 #1058

Closed
sharwell opened this issue Jul 26, 2015 · 2 comments
Closed

Proposal: Permanently disable rule SA1409 #1058

sharwell opened this issue Jul 26, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@sharwell
Copy link
Member

Rule SA1409 (RemoveUnnecessaryCode) has two characteristics which make it a particularly poor rule for StyleCopAnalyzers:

  • It is poorly defined (what is or is not "necessary"?)
  • It is largely a semantic rule as opposed to a syntax-based style rule

I propose rule SA1409 be permanently disabled, and allow other tools which focus on semantics (e.g. a future "FxCopAnalyzers") to pick up this diagnostic at a later time.

@Noryoko
Copy link
Contributor

Noryoko commented Jul 26, 2015

I agree. This should be handled by something like FxCopAnalyzers.

@pdelvo
Copy link
Member

pdelvo commented Jul 26, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants