Use System.Net.Http from NET Framework rather than NuGet #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping? As many others, we've had various strange issues related to System.Net.Http because of Microsofts error. Took us a while to investigate it more in depth to find out Neo4jClient was the culprit. It would be nice to get this merged. |
The System.Net.Http package on NuGet was put there as an OOB update where Microsoft also tried to add extra functionality for NET Framework developers. This experiment didn't work, but Microsoft didn't want to pull the package from NuGet as people would get strange errors. Microsoft has written a post-mortem on GitHub, ref https://github.com/dotnet/corefx/issues/17522#issuecomment-338418610 NOTE: I also had to remove NETStandard.Library from NET Framework as that depends on System.Net.Http from NuGet.
simendsjo
force-pushed
the
System.Net.Http-from-NETFramework
branch
from
3666985 to
d568e35
Compare
|
Ping -- this is probably a problem for everyone on NET Framework, but the issues it causes is difficult to pin back to the broken Microsoft package. |
|
Sorry @simendsjo for some reason I'm not getting notified of these, let me look at it and I'll try to get it in today |
|
It's building... :o Thanks for this and the other one! Sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The System.Net.Http package on NuGet was put there as an OOB update where
Microsoft also tried to add extra functionality for NET Framework developers.
This experiment didn't work, but Microsoft didn't want to pull the package from
NuGet as people would get strange errors.
Microsoft has written a post-mortem on GitHub, ref
https://github.com/dotnet/corefx/issues/17522#issuecomment-338418610
NOTE: I also had to remove NETStandard.Library from NET Framework as that
depends on System.Net.Http from NuGet.