refactor fs use #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicBurkart
force-pushed
the
refactor-caching-mechanism
branch
from
a543941 to
30934e5
Compare
DominicBurkart
force-pushed
the
refactor-caching-mechanism
branch
from
30934e5 to
2e6a64c
Compare
|
hmm, include_dir!(".") in extract_function is taking the home dir for the turbolift_internals project, not the home dir of the project importing turbolift. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we are doing a lot of reads and writes to the file system, which may be problematic with the current state of procedural macros. This PR is focused on minimizing unnecessary FS activity and using more stable means to access the FS (e.g. via macros like
include_str!instead of by opening and reading files).As a bonus, we expect this to reduce compile time.