Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Better Stack status page template #581

Conversation

dmajda
Copy link
Contributor

@dmajda dmajda commented Feb 20, 2025

Description

H! At Better Stack, we're implementing Domain Connect so that users can easily add CNAME records for status pages on their own domains. This PR adds a template to allow that.

Type of change

Please mark options that are relevant.

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

Please mark the following checks done

Example variable values

The template doesn't use any variables.

Copy link

Linter OK:

Linter result for betterstack.com.status-page.json

@dmajda dmajda force-pushed the add-better-stack-status-page-template branch 2 times, most recently from d1df8f6 to 609ff14 Compare February 20, 2025 11:09
@dmajda dmajda changed the title Add a Better Sack status page template Add Better Sack status page template Feb 20, 2025
@dmajda dmajda changed the title Add Better Sack status page template Add Better Stack status page template Feb 20, 2025
Copy link
Member

@pawel-kow pawel-kow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily an issue with the template. It's good and simple, but so short TTL would increase load on DNS servers, so there should be a good reason.

@dmajda dmajda force-pushed the add-better-stack-status-page-template branch from 609ff14 to 3ef7d75 Compare February 20, 2025 12:28
@dmajda dmajda requested a review from pawel-kow February 20, 2025 12:30
@pawel-kow pawel-kow added this pull request to the merge queue Feb 20, 2025
Merged via the queue into Domain-Connect:master with commit d89cf06 Feb 20, 2025
2 checks passed
@dmajda
Copy link
Contributor Author

dmajda commented Feb 20, 2025

Thanks for a super-fast review & merge! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants