Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v19.0.4 line extrafield in proposal cannot be saved, if empty #31890

Closed
priojk opened this issue Nov 15, 2024 · 0 comments
Closed

v19.0.4 line extrafield in proposal cannot be saved, if empty #31890

priojk opened this issue Nov 15, 2024 · 0 comments
Assignees
@priojk
Labels
Bug This is a bug (something does not work as expected) Event: DevCamp 2024 Munich

Comments

@priojk
Copy link
Contributor

priojk commented Nov 15, 2024 •
edited
Loading

Bug

Proposal line extrafield with contents: contents cannot be completely deleted - will keep the original contents after save. However, changes of the contents get successfully stored.

Dolibarr Version

Confirmed at least on v19.0.2, v19.0.3 and v19.0.4

Environment PHP

8.1

Environment Database

MariaDB

Steps to reproduce the behavior and expected behavior

  1. create extrafield of type String for proposal line
  2. create a proposal with one line with text in extrafield
  3. click on pencil, delete the text of the extrafield and press save

The extrafield now still contains the original text, log has a SQL error
@priojk priojk added the Bug This is a bug (something does not work as expected) label Nov 15, 2024
priojk added a commit to priojk/dolibarr that referenced this issue Nov 29, 2024
@priojk
FIX Dolibarr#31890 storing empty extrafield
95f6644 
Trying to delete an existing contents of the extrafield was ignored, the original contents was still present. Empty input needs explicit handling.
priojk added a commit to priojk/dolibarr that referenced this issue Nov 29, 2024
@priojk
FIX Dolibarr#31890 store empty line extrafields
52fc94e 
If a line extrafield had originally some contents, after deleting it and submitting it as empty, the extrafield was not stored but the original contents kept
@eldy eldy closed this as completed in 18775c0 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@priojk priojk

Labels
Bug This is a bug (something does not work as expected) Event: DevCamp 2024 Munich
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tiaris @priojk