Skip to content

Commit

Permalink
browserify-vendor: allow custom dependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
stkao05 committed Nov 13, 2017
1 parent 591d7e3 commit b2c4ed8
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 17 deletions.
28 changes: 16 additions & 12 deletions lib/tasks/browserify-vendor.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,22 +19,26 @@ function buildVenderBundle(moduleList, dest, forProduction) {
var bundler = browserify();

moduleList.forEach(function(e) {
bundler.require(e);
if (typeof e === "object") {
bundler.require(e.path, {expose: e.expose});
} else {
bundler.require(e);
}
});

//NOTE: by setting "process.env.NODE_ENV", some modules (i.e. reactjs)
//will automatically be imported with production setting.
if (forProduction) {
process.env.NODE_ENV = 'production';
bundler.transform(envify({
NODE_ENV: 'production'
}));
} else {
process.env.NODE_ENV = 'development';
bundler.transform(envify({
NODE_ENV: 'development'
}));
}
if (forProduction) {
process.env.NODE_ENV = 'production';
bundler.transform('envify', {
NODE_ENV: 'production'
});
} else {
process.env.NODE_ENV = 'development';
bundler.transform('envify', {
NODE_ENV: 'development'
});
}

return bundler.bundle()
.on("error", notify.onError({
Expand Down
5 changes: 0 additions & 5 deletions lib/tasks/browserify.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,11 @@
var gulp = require('gulp');
var uglify = require('gulp-uglify');
var notify = require("gulp-notify");
var sourcemaps = require("gulp-sourcemaps");
var path = require('path');
var source = require('vinyl-source-stream');
var browserify = require('browserify');
var watchify = require('watchify');
var runSequence = require('run-sequence');
var rename = require('gulp-rename');
var buffer = require('vinyl-buffer');
var envify = require('envify/custom');

var config = require('../config').browserify


Expand Down

0 comments on commit b2c4ed8

Please sign in to comment.