Remove Lodash webpack plugin. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DFurnes
force-pushed
the
remove-webpack-plugin
branch
from
d172d21 to
ee301cf
Compare
itsjoekent
approved these changes
Apr 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This fixes an issue where
_.getwas unexpectedly returningundefinedbecause of thepathsoptimization in LodashWebpackPlugin. It turns out this optimizes a bit more aggressively than I thought when I added it – it will remove support for all the features in this list unless you specifically opt in, which is a bit too much cognitive overhead I think.Plus, most of our space savings came from adding babel-plugin-lodash to our Babel config (which optimizes our imports), so enabling this only adds ~10kb to the final builds.